Feat(web-react): Use different resize observer hook #1645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for spirit-design-system ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for spirit-design-system-storybook ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
literat
force-pushed
the
fix/DS-1465-collapse-resize-observer
branch
from
15eed5d to
9d15df4
Compare
literat
requested review from
pavelklibani,
curdaj and
a team
as code owners
literat
force-pushed
the
fix/DS-1465-collapse-resize-observer
branch
from
26070a7 to
51571d8
Compare
literat
force-pushed
the
fix/DS-1465-collapse-resize-observer
branch
2 times, most recently
from
b86a744 to
64b8cb1
Compare
…ow object refs #DS-1465
literat
force-pushed
the
fix/DS-1465-collapse-resize-observer
branch
from
20788a7 to
2d1cea7
Compare
curdaj
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Switch from the
@react-hooks/resize-observertousehooks-ts. First one is directly usingwindow.ResizeObserverwithout any condition and this fails on Next.js SSR. The second one has a better usage behind theisMountedcondition.Additional context
Issue reference
https://jira.almacareer.tech/browse/DS-1465